-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unread message clearing on convo change #17380
Conversation
c261395
to
27bc40b
Compare
27bc40b
to
ad42e8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #17380 +/- ##
==========================================
+ Coverage 46.05% 46.07% +0.01%
==========================================
Files 753 753
Lines 24736 24737 +1
Branches 5669 5669
==========================================
+ Hits 11392 11397 +5
+ Misses 11913 11910 -3
+ Partials 1431 1430 -1 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Noticed an issue where unread messages would be cleared when changing conversations and going back to the original convo.
Appears to be a regression introduced in #17158
Screenshots/Screencast (for UI changes)
Before:
https://github.com/wireapp/wire-webapp/assets/37285713/65fb81b5-93d7-4222-8b96-f63004aba8c2
After:
https://github.com/wireapp/wire-webapp/assets/37285713/772f3419-4049-474a-a0cb-f3228eefb053
Checklist